From 369ab820bddfecfdfb99d02123a79ec619ba1573 Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Sat, 21 Jul 2018 18:12:37 +0200 Subject: [PATCH] switch places for file op to avoid an overwrite (Coverity) --- camlibs/soundvision/soundvision.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/camlibs/soundvision/soundvision.c b/camlibs/soundvision/soundvision.c index d9a0ad1f8..cecdd3de5 100644 --- a/camlibs/soundvision/soundvision.c +++ b/camlibs/soundvision/soundvision.c @@ -119,20 +119,20 @@ int camera_abilities(CameraAbilitiesList *list) { a.speed[0] = 0; a.usb_vendor = models[i].idVendor; a.usb_product= models[i].idProduct; - + /* All should support image capture */ a.operations = GP_OPERATION_CAPTURE_IMAGE; - + /* Folders not supported on any */ a.folder_operations = GP_FOLDER_OPERATION_NONE; - - /* Dshot compat can upload files */ - if (models[i].idVendor==0x0919) { - a.file_operations|=GP_FOLDER_OPERATION_PUT_FILE; - } - + a.file_operations = GP_FILE_OPERATION_PREVIEW | GP_FILE_OPERATION_DELETE; + /* Dshot compat can upload files */ + if (models[i].idVendor == 0x0919) { + a.file_operations|=GP_FOLDER_OPERATION_PUT_FILE; + } + gp_abilities_list_append(list, a); }