From 9bd47e22af2ae3d3fad0813e2b9da4c5bca92f44 Mon Sep 17 00:00:00 2001 From: Siim Meerits Date: Mon, 3 Aug 2020 00:26:37 +0300 Subject: [PATCH] Fix panasonic camlib compilation warnings. * l859/l859.c: This seems to be a bug in the code due to missing 'break' statement. It is also possible that image preview functionality did not really work. In any case this fix should not make things worse. * dc1580.c: Fixes signed-unsigned comparison issue. --- camlibs/panasonic/dc1580.c | 2 +- camlibs/panasonic/l859/l859.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/camlibs/panasonic/dc1580.c b/camlibs/panasonic/dc1580.c index d7df2f903..462a7a5b6 100644 --- a/camlibs/panasonic/dc1580.c +++ b/camlibs/panasonic/dc1580.c @@ -76,7 +76,7 @@ static uint8_t dsc2_checksum(char *buffer, int size) { static int dsc2_sendcmd(Camera *camera, uint8_t cmd, long int data, uint8_t sequence) { - int i; + unsigned int i; DEBUG_PRINT_MEDIUM(("Sending command: 0x%02x, data: %i, sequence: %i.", cmd, data, sequence)); diff --git a/camlibs/panasonic/l859/l859.c b/camlibs/panasonic/l859/l859.c index 855975b9e..2645535bd 100644 --- a/camlibs/panasonic/l859/l859.c +++ b/camlibs/panasonic/l859/l859.c @@ -494,6 +494,7 @@ static int get_file_func (CameraFilesystem *fs, const char *folder, break; case GP_FILE_TYPE_PREVIEW: size = l859_selectimage_preview(camera, index); + break; default: return (GP_ERROR_NOT_SUPPORTED); }