Commit e47c13fd8e updates the
libgphoto2_port version from 0.12.0 to 0.12.1, but fails to
update libgphoto2_port/NEWS accordingly.
This updates libgphoto2_port/NEWS with the 0.12.1 version number,
thus fixing the "make distcheck" target's part checking NEWS.
Change the libgphoto2_port version from 0.12.0 to 0.12.1 so that
the libgphoto2 pkgconfig files can require libgphoto2_port >= 0.12.1
due to new symbols added.
This will not catch all possible build/install/link messups, but
will not hurt anyone and could catch some messups.
Introduce GP_CHECK_PROG macro to allow users to override
the autodetection of tools, instead of the autodetection
overriding the user's explicit wish.
GP_CHECK_PROG([SORT, [sort], [text line sorting tool])
will now allow calling
./configure SORT="mysort"
and have subsequent builds use that given value without
checking PATH. When calling `configure` without SORT=,
AC_PATH_PROG will look for `sort` in `PATH` and set
`SORT` to the value it has found.
For comparison, here is the old buggy method:
AC_ARG_VAR([SORT], [sort], [text line sorting tool])
AC_PATH_PROG([SORT], [sort], [no])
When called as `configure SORT="mysort"`, the expanded
AC_PATH_PROG will just look in `PATH` for `sort` and
set `SORT` to the `sort` it found, completely ignoring
the SORT= value given on the `configure` command line.
Only sleep after configure warning message if the output goes to
an interactive terminal (isatty()) and therefore sleeping actually
has a chance to be noticed by someone watching.
It makes more sense to use the provided m4_pattern_ignore()
macro than writing our own error messages.
Yes, our own error message could be more helpful to the
uninitiated user by mentioning the package and the m4 file
name to install which provide the required macro.
However, those file names and package names can and do change
with time or by operating system.
Remove additional AM_CONDITIONAL definitions for HAVE_LIBCURL
and HAVE_LIBXML2.
Those two AM_CONDITIONALS are already defined by GP_CHECK_LIBRARY.
If not having the addtional definitions exposes a bug, then that
bug should be fixed, not papered over with the additional definitions.
Complete what adding the gp_init_localedir() function implied:
* only set success flag in the success case
* consistent use of "initialize" spelling
* add analogous gp_port_init_localedir() function
* implement and document edge cases
* update NEWS
The function is called from gp_abilities_list_new() so existing code
will carry on working as before. Non-standard installations of
libgphoto2 can call the initialisation function with their choice of
locale dir. The function includes code to ensure it's only run once.
Use parallel make for builds. We use the GNU coreutils'
"nproc" utility to determine the number of cores available
for us to use. We then tell make to launch up to that number
of processes (-j$(nproc)) in parallel, but only if the system
load is below $(nproc) (-l$(nproc)).
That should make reasonably good use of however many cores github
makes available to us, while not overloading the build server
or the build server VM.
Require gettext >= 0.19.1 (from 2014-06-10), which both works properly
when building on many cores, and is also the first gettext release
whose po/Makefile.in.in allows disabling rebuilding of the *.po files
on normal (non dist target) builds.
The new po/Makefile.in.in rules fix "make distcheck" consistently
failing to remove ../../../po/libgphoto2-6.pot when running
"make -j$(nproc) distcheck" on a 12 core system:
rm: cannot remove '../../../po/libgphoto2-6.pot': Permission denied
The "make dist" (and "make distcheck") targets will still update the
po files by default, but that could also be disabled in po/Makevars
if we wanted to separate updating the *.po files for translation from
"make dist" or "make distcheck" at any time in the future.
As gettext-0.19.1 was released almost 8 years ago, this is the newest
build tool release requirement for bulding libgphoto2.
If you ever need to build a 2022 or later libgphoto2 from git on a
system with pre 0.19.1 gettext, you can can always prepare a tarball
running "make dist" on a system with gettext 0.19.1 or later, and
build that tarball on the older machine.
Consistently spell initialize the AE way. Excluding the *.po files,
we had 293 occurrences of the word, of which 279 used the AE
spelling, so changing everything to AE for consistency is not
much of a leap.
I have found good arguments from clang developers for not
using -Weverything after all. Instead, -Wmost is the
preferred option to enable the most warnings reasonable.
Apparently, -Weverything can a set of warnings where one
warning contradicts the other and is really only useful
people developing clang itself.
Values determined by changing values on the camera and then re-reading
the property. While in the camera HEIF is accompanied by a mention of
chroma sampling, 4:2:2 or 4:2:0, this is not presented in
CompressionSettings, so it must be in one of the Unknown DPC code's.
